feat(substrait): support order_by in aggregate functions #13114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
approved these changes
Oct 25, 2024
Contributor
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Clear improvement with tests ✨
Thanks for fixing this.
datafusion/substrait/tests/testdata/test_plans/aggregate_sorted_no_project.substrait.json
Outdated
Show resolved
Hide resolved
bvolpato
force-pushed
the
substrait-aggregate-expr
branch
2 times, most recently
from
3f11b77 to
a44444e
Compare
andygrove
approved these changes
Oct 25, 2024
bvolpato
force-pushed
the
substrait-aggregate-expr
branch
from
2e2c9fc to
224ddf4
Compare
Contributor
Author
Thank you! Sorry, I've missed a |
Contributor
|
Thanks @bvolpato @vbarua and @andygrove Sorry for the delay in merging this one |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13113.
Rationale for this change
Adding support to a new sort of expression (ORDER BY within aggregation functions) in the Substrait consumer.
For example:
What changes are included in this PR?
The wiring to go from Substrait's SortField to DataFusion's SortExpr in the context of aggregation measurements.
The actual conversion already existed at
from_substrait_sortsbecause of window functions - I just hooked up in the context of aggragations as well.Are these changes tested?
I added a roundtrip test and also added a logical plan to check if everything was decoded correctly. Open to more ideas on how to better unit test this.
Are there any user-facing changes?
n/a